Bug with package tag in a global function

[marcimat]

Hi,

With 2.6.0 6c7cb9c , a little file creates a Fatal Error :

/**
 * Demo File
 *
 * Same bug with or without file @package tag.
 *
 * @package Demo
**/

/**
 * A demo function
 *
 * @package Other
**/
function demo() {}

Run with :

autodoc/vendor/phpdocumentor/phpdocumentor/bin/phpdoc -d work/input/demo -t work/output/demo --parseprivate

Makes :

Parsing [...]/work/input/demo/demo.php
PHP Fatal error:  Call to a member function add() on a non-object in  [...]/autodoc/vendor/phpdocumentor/phpdocumentor/src/phpDocumentor/Descriptor/Builder/Reflector/AssemblerAbstract.php on line 49

In fact, it tries to make ->add() on the string "Other"…

[marcimat]

A possible correction that seems to work (I'm not sure in fact ^^) : use the specific method setPackage() into the FunctionAssembler, as this is done in ClassAssembler.

diff --git a/src/phpDocumentor/Descriptor/Builder/Reflector/FunctionAssembler.php b/src/phpDocumentor/Descriptor/Builder/Reflector/FunctionAssembler.php
index d772043..01e057a 100644
--- a/src/phpDocumentor/Descriptor/Builder/Reflector/FunctionAssembler.php
+++ b/src/phpDocumentor/Descriptor/Builder/Reflector/FunctionAssembler.php
@@ -62,7 +62,7 @@ class FunctionAssembler extends AssemblerAbstract
         $descriptor->setFullyQualifiedStructuralElementName($reflector->getName() . '()');
         $descriptor->setName($reflector->getShortName());
         $descriptor->setLine($reflector->getLinenumber());
-        $descriptor->getTags()->set('package', $this->extractPackageFromDocBlock($reflector->getDocBlock()) ? : '');
+        $descriptor->setPackage($this->extractPackageFromDocBlock($reflector->getDocBlock()) ? : '');
         $descriptor->setNamespace($this->getFullyQualifiedNamespaceName($reflector));
     }

[mvriel]

Actually setPackage is meant to be used with PackageDescriptor objects that are created later. This was a rather unfortunate choice of method naming :S

[mvriel]

This issue is resolved in PR #1334 and will be included in a hotfix release this week

[mvriel]

FYI: I just released the new version :)