GH #1521: Remove logging from application #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8fc3387.
Added options to override files when copying (in method executeQueryCopy)
…-configuration Parser initialized with correct markers
…tignore-update Composer install creates two files which should be ignored
…moving-obsolete-code Removing code which was most likely a left over from a refactor and not ...
Override files when copying
Upgrade to behat3
Added check if iconv is loaded
…ssing-inheritance-for-variables Issue 1432 missing inheritance for variables
Fixing broken tests
Fix faulty "missing argument in phpDoc block" check
Conflicts: CHANGELOG.md
Conflicts: .gitignore CHANGELOG.md composer.json composer.lock features/2. Configuration/1. Initialize configuration using interactive task.feature features/bootstrap/FeatureContext.php src/phpDocumentor/Descriptor/ArgumentDescriptor.php src/phpDocumentor/Descriptor/Builder/Reflector/MethodAssembler.php src/phpDocumentor/Descriptor/ClassDescriptor.php src/phpDocumentor/Descriptor/MethodDescriptor.php src/phpDocumentor/Parser/Command/Project/ParseCommand.php src/phpDocumentor/Plugin/Twig/Writer/Twig.php tests/unit/phpDocumentor/BootstrapTest.php tests/unit/phpDocumentor/Command/Helper/LoggerHelperTest.php tests/unit/phpDocumentor/Descriptor/ArgumentDescriptorTest.php tests/unit/phpDocumentor/Descriptor/Builder/Reflector/MethodAssemblerTest.php tests/unit/phpDocumentor/Descriptor/ClassDescriptorTest.php tests/unit/phpDocumentor/Descriptor/Filter/StripIgnoreTest.php tests/unit/phpDocumentor/Descriptor/Filter/StripInternalTest.php tests/unit/phpDocumentor/Descriptor/MethodDescriptorTest.php
The logging feature was not particularly useful and there were complaints about it and that parts did not seem to be logged properly. Due to this and the seemingly unnecesary dependencies I chose to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging feature was not particularly useful and there were complaints
about it and that parts did not seem to be logged properly. Due to this and
the seemingly unnecesary dependencies I chose to remove it.