Feature/configuration factory

[rgeraads]

The ConfigurationFactory that converts phpdocumento2 / phpdocumento3 xml to an array

[mvriel]

Hi @rgeraads,

You're off to a good start! During the code review I have found the following points of improvements:

• Can you please move the ConfigurationFactory to the \phpDocumentor namespace?
• Can you move/use the xsd to/in the /data/xsd folder?
• I am missing the replaceLocation() and get() method (see Class Diagram); it seems you renamed that to convert?
• The XML is retrieved in the constructor; can you move that to the get() method and in the constructor just record the URI?

  This is because the configuration file may be overridden during execution of the application and we want to load the configuration at the latest moment, and that is in the get. Please keep in mind that the get may be called multiple times and building the configuration should not reoccur unless the URI has changed. This will save performance.

• A significant amount of information is missing from the generated array for the phpDocumentor 2 XML; the output folder and source files are not set
• Can you de-duplicate the defaults? I see the same defaults (such as default template) being used multiple times. My preferred option would be a private property 'defaults' that can also be overridden via the constructor
• Can you make the xsd location configurable in the constructor? Since we could have multiple XSD files (one for each version) I think it would be best to add that to the defaults array

In addition to the above I will add a few comments inline with the source.

[mvriel]

this should also come from the xml

[mvriel]

the default for extensions is php, php3 and phtml; by omitting content here the parser won't pick up on any file

[mvriel]

My apologies for the number of points; I noticed some things that would quite possibly lead to issues later on.