Method to update attributes by userid in user_attribute (API 1) #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't merge this one, it has conflicts. Can you rebase and redo the PR? |
|
Fixed. |
|
Thanks. I got the testing back in action https://travis-ci.org/phpList/phplist-plugin-restapi I would be nice to add unit tests for your new methods :-) |
|
In the following weeks I will try to make them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method to update a list of attributes that are present in the table, passing a userid and a dictionary [{"attributeid": "value", ... }], returning all attributes of that userid even though they have not been updated. Also, through another method, you can update one attribute individually.
Also I intend to create a method for delete attributes.