[TASK] Drop support for PHP < 5.6 #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 5.3, 5.4 and PHP 5.5 have reached their end of life and thus are not supported anymore (not even with security updates). So PHPList will not support it anymore, either. This will also fix the Travis build which has been broken for PHP 5.3.
|
|
By the way, the travis build will resolve once I merge dev33 into master, which will be soon. |
|
@michield So it would be okay to at least drop support for 5.3? Then I'll create a PR for that. |
|
@michield And would it make sense to include PHPMailer via composer? Then PhpList could always have the latest version. |
|
I guess we can drop 5.3. The main reason I kept it for now, is that it only fails on some unused files in PHPMailer, so basically phpList still is fine with 5.3 PHPMailer via composer is a nice idea. Currently we only use composer for the CI stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 5.4 and PHP 5.5 have reached their end of life and thus are not
supported anymore (not even with security updates). So PHPList will
not support it anymore, either.
This will also fix the Travis build which has been broken for PHP 5.3.