Mantis 18706 - Repeat message processing tries to copy an index #174
Conversation
Explicitly set the finishsending date when copying a message.
| @@ -1907,6 +1908,16 @@ function repeatMessage($msgid) | |||
| unset($e['second']); | |||
| setMessageData($newid, 'embargo', $e); | |||
|
|
|||
| $finishSending = time() + DEFAULT_MESSAGEAGE; | |||
| $finish = array( | |||
There was a problem hiding this comment.
I find both variable names very similar, and the different names don't make the differences clear. Proposal: finishTimestamp and finishDateParts.
What do you think?
There was a problem hiding this comment.
I think it is clear that $finish is an array of parts of dates. To understand why it is like that you need to look into setMessageData(). I'm happy with the way it is.
There was a problem hiding this comment.
I'm just trying to help your PR get into the code base in its best, clearest, most readable form. If you'd prefer to not get these suggestions, please let me know.
| $columnsToCopy = array_diff( | ||
| array_keys($DBstruct['message']), | ||
| array( | ||
| 'id', 'entered', 'modified', 'embargo', 'status', 'sent', 'processed', 'astext', 'ashtml', | ||
| 'astextandhtml', 'aspdf', 'astextandpdf', 'viewed', 'bouncecount', 'sendstart', 'uuid', | ||
| ) | ||
| ); | ||
| $columnsToCopy = preg_grep('/^index_/', $columnsToCopy, PREG_GREP_INVERT); |
There was a problem hiding this comment.
I propose changing the old variable name in line 1874 to something different as it now does not represent the columns to copy anymore, but more columns.
There was a problem hiding this comment.
The variable has a "lifetime" of 10 lines, so it is not difficult to work out how it is being used. I am happy the way it is.
Explicitly set the finishsending date when copying a message.
Avoid trying to copy indices when copying a message.
Explicitly set the finishsending date when copying a message, otherwise eventually a repeated campaign will not be sent because finishsending is in the past.