New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enable a plugin that does not meet its dependencies #379

Merged
merged 1 commit into from Jul 29, 2018

Conversation

Projects
None yet
2 participants
@bramley
Contributor

bramley commented Jul 21, 2018

There is a problem when a plugin is updated and then does not meet its dependencies.

On the Plugins page it is correctly shown as disabled due to dependency checks, but the processing in pluginlib.php, on each page load, treats it as still being enabled and the plugin's menu items etc are still displayed. Depending on what the dependencies actually are, this can cause a failure that can be difficult to diagnose.

This change adds a test of whether each plugin can be enabled and ignores plugins that are already enabled but fail the test.

@michield michield merged commit ae9bbcc into phpList:master Jul 29, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michield

This comment has been minimized.

Member

michield commented Jul 29, 2018

@samtuke @xh3n1

It may be useful to find some place to notify about this, as it will disable plugins that are enabled during an upgrade.

I'll create a mantis issue to review the UX here.

@michield

This comment has been minimized.

Member

michield commented Jul 29, 2018

@bramley bramley deleted the bramley:plugin_dependencies branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment