Do not enable a plugin that does not meet its dependencies #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem when a plugin is updated and then does not meet its dependencies.
On the Plugins page it is correctly shown as disabled due to dependency checks, but the processing in pluginlib.php, on each page load, treats it as still being enabled and the plugin's menu items etc are still displayed. Depending on what the dependencies actually are, this can cause a failure that can be difficult to diagnose.
This change adds a test of whether each plugin can be enabled and ignores plugins that are already enabled but fail the test.