Add option to disable the automatic updater #457
Conversation
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
There was a problem hiding this comment.
Please also add an entry here for documentation: https://github.com/phpList/phplist3/blob/master/public_html/lists/config/config_extended.php
Once the PR is merged please add an entry here for the new constant also: https://resources.phplist.com/system/config/constants
xh3n1
force-pushed
the
disable-updater
branch
from
e32b3e8
to
6ab50ea
Compare
|
@samtuke added the entry for documentation. |
| @@ -606,6 +606,10 @@ | |||
| if (!defined('USERSPAGE_MAX')) { | |||
| define('USERSPAGE_MAX', 1000); | |||
| } | |||
| // if false, it will disable the automatic updater. | |||
| if (!defined ('ALLOW_UPDATER')){ | |||
There was a problem hiding this comment.
it would be nice here to verify some requirements, like file and directory permissions and then to disable it automatically when those requirements are not met. That will be a better UX, suppressing the links in the UI when they cannot be used anyway.
|
Where might the logic for those checks go? Users should to be prompted to fix permissions in order to be able to upgrade. |
Co-Authored-By: xh3n1 <myrtajxheni@gmail.com>
|
I think this PR is good to go, The files permission check is done on the updater and the update cannot continue without users fixing the permission of displayed files. After that they do that, they can try again. |
Mantis: https://mantis.phplist.org/view.php?id=19654