Mantis 17918 - plugins control authentication #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify selection of admin authentication class
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the problem of admins being read-only on the admins page, and also (I think) simplifies the selection of the admin authentication class.
admins.php - correct the test of whether authentication is being done externally
phpListAdminAuthentication.php - change to not be a plugin, just a class.
pluginlib.php - sets $authenticationplugin only for a "real" plugin. Remove code that handles phpListAdminAuthentication as a plugin.
index.php - now $authenticationplugin is set if a plugin wants to handle authentication, otherwise fallback to the internal class. Use the already-existing instance of the plugin class instead of creating a new one.