Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimmers do not work in Domoticz config #1

Closed
ghosmar opened this issue Dec 10, 2013 · 21 comments

Comments

@ghosmar
Copy link

commented Dec 10, 2013

mydomo

    [undef_undef_120] => Array
        (
            [raw_value1] => Set Level: 53 %
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Set Level: 53 %, Level: 53 %
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-11 16:33:02
                    [Level] => 53
                    [LevelInt] => 8
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Set Level: 53 %
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => undef
            [type] => undef
            [uid] => undef_undef_120
            [img_type] => undef
        )
@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2013

Dimmers are not currently implemented in Domoticz. (I've no dimmer to test)

Please remove the comment in front of //$this->Debug('Devices',$this->devices) in the pmd/inc/api/domoticz/api_client.php (near line 216), load any page, and copy/paste me the result here.

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2013

checkout the latest 'develop' branch. Domoticz dimmers should be recognized.

and may be commands might work (experimental). Please tell me if it works!

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 11, 2013

Dimmers are recognized and I can switch them on and off. Now we need a slider to set a level ....

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2013

should be ther when you click on the white part of the button (where the level is shown)

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 11, 2013

This is what I get when I click on the white part (in Chrome and IE):

slider

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2013

enable debug in config or go to /utils/reset (this is certainly a cache issue)

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2013

BTW I'll never fix any IE issue myself, so please make all your tests in Chrome, or any truly w3c compliant browser

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2013

If it work, also please confirm that at 100, dimmers are totally FULL lighted

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 12, 2013

The sliders are working after cache clean. At 100% tge light are fully on. You can remove the "not working" part ...

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2013

Could you please make intensive checks (I've no dimmers myself to test) that you can, dim, then switch OFF, dim again (automatically switch ON)...etc...

Its difficult to explain,but : Is the GUI working as expected : immediate correct behaviour and icon/display feedback when you click, or dim.

I want it to be perfect! We are making a GUI that even a child, A WIFE, or a grand mother would immediately understand... graphic design apart (at this time ...). It must be as convenient as a physical button.

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 17, 2013

I had finally had some time to test the dimmers. I see the following:

Problem 1:

  • Dimmer = ON (40 %)
  • Switch dimmer --> State = OFF (0 %)
  • Next screenupdate --> State = OFF (40 %)
  • Switch dimmer -> State = ON (100 %) but actual lamp is 40%
  • Next screen update -> State = ON (40%)

So after the screenupdate the correct screen is shown

Problem 2:

  • When setting a new level on the slider and clicking on the number the slider is removed
  • When clicking again on the number the slider shows the previous value
@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2013

FYI I do need your feedback to on #1 and #3 to release v0.134 !
Please report ASAP !

@pepijng

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2013

The only problem i experienced:
When turning the dimmer On it displays 100 but after the screen update it get's its (last)value from the API and shows the correct value. The same occurs when turning the dimmer off, it goes to 0 and after it updates it shows the value in the API.

The API behaviour is normal because 433Mhz is one way you cannot request the dimmer state or value direct from the dimmer hardware. That's why it is stored in Domoticz and passed in the API.

So that's why for example you receive a value of 40 when the dimmer is turned off.

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2013

It may have something in common with the way I internally scale the Dimmer value.
Could you please provide me 3 dumps (/devices?dump) of a dimmer device after changing its value in Domoticz (not from PMD):

  • When the dimmer is at 0% (Off)
  • When the dimmer is at 100% (Full On)
  • When the dimmer is at 50%

Then the same 3 Dump, but while changing the value From PMD (using the SLIDER only)

  • When the dimmer is at 0% (Off)
  • When the dimmer is at 100% (Full On)
  • When the dimmer is at 50%

Thank you for the feedback

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2013

Please make PMD dimmers Dumps, with the latest develop branch (including commit 7a5d68f ). It should already be better!

@remb0

This comment has been minimized.

Copy link

commented Dec 18, 2013

It works. but I use dutch translations and see as title: eettafel (not working) what is this not working?

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 18, 2013

(not working) = Beta comment!

"It works" is not enought! I need a full report before releasing it ;-)

So please provide the asked Dumps, and/or make extensive tests and report results, like @ghosmar have done.

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 18, 2013

From Domoticz -> Dimmer off

[command_dimmer_120] => Array
        (
            [raw_value1] => Off
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Off
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-18 22:59:08
                    [Level] => 53
                    [LevelInt] => 8
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Off
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => command
            [type] => dimmer
            [value] => 47
            [uid] => command_dimmer_120
            [state] => off
            [dim_steps] => 15
            [img_type] => dimmer_off
        )

From Domoticz -> Dimmer 100 %

    [command_dimmer_120] => Array
        (
            [raw_value1] => Set Level: 100 %
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Set Level: 100 %, Level: 100 %
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-18 23:01:59
                    [Level] => 100
                    [LevelInt] => 16
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Set Level: 100 %
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => command
            [type] => dimmer
            [value] => 100
            [uid] => command_dimmer_120
            [dim_steps] => 15
            [state] => on
            [img_type] => dimmer_on
        )

From Domoticz -> Dimmer 46 %

Array
(
    [command_dimmer_120] => Array
        (
            [raw_value1] => Set Level: 46 %
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Set Level: 46 %, Level: 46 %
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-18 23:04:26
                    [Level] => 46
                    [LevelInt] => 7
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Set Level: 46 %
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => command
            [type] => dimmer
            [value] => 40
            [uid] => command_dimmer_120
            [dim_steps] => 15
            [state] => on
            [img_type] => dimmer_on
        )

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 18, 2013

PMD -> Dimmer off

    [command_dimmer_120] => Array
        (
            [raw_value1] => Off
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Off
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-18 23:08:07
                    [Level] => 46
                    [LevelInt] => 7
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Off
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => command
            [type] => dimmer
            [value] => 40
            [uid] => command_dimmer_120
            [state] => off
            [dim_steps] => 15
            [img_type] => dimmer_off
        )

PMD -> Dimmer 100 %

    [command_dimmer_120] => Array
        (
            [raw_value1] => Set Level: 100 %
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Set Level: 100 %, Level: 100 %
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-18 23:08:49
                    [Level] => 100
                    [LevelInt] => 16
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Set Level: 100 %
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => command
            [type] => dimmer
            [value] => 100
            [uid] => command_dimmer_120
            [dim_steps] => 15
            [state] => on
            [img_type] => dimmer_on
        )

Note: State of the dimmer is still displayed as off blue

PMD -> Dimmer 50 %

Array
(
    [command_dimmer_120] => Array
        (
            [raw_value1] => Set Level: 46 %
            [address] => 120
            [name] => Lamp raam
            [battery_level] => 255
            [signal_level] => 7
            [raw] => Array
                (
                    [BatteryLevel] => 255
                    [CustomImage] => 0
                    [Data] => Set Level: 46 %, Level: 46 %
                    [Favorite] => 1
                    [HardwareID] => 4
                    [HardwareName] => RFXCOM
                    [HaveDimmer] => 1
                    [HaveGroupCmd] => 1
                    [ID] => 2010000
                    [Image] => Light
                    [IsSubDevice] => 
                    [LastUpdate] => 2013-12-18 23:10:32
                    [Level] => 46
                    [LevelInt] => 7
                    [MaxDimLevel] => 16
                    [Name] => Lamp raam
                    [Notifications] => false
                    [SignalLevel] => 7
                    [Status] => Set Level: 46 %
                    [SubType] => AC
                    [SwitchType] => Dimmer
                    [SwitchTypeVal] => 7
                    [Timers] => false
                    [Type] => Lighting 2
                    [TypeImg] => dimmer
                    [Unit] => 1
                    [Used] => 1
                    [UsedByCamera] => 
                    [idx] => 120
                )

            [class] => command
            [type] => dimmer
            [value] => 40
            [uid] => command_dimmer_120
            [dim_steps] => 15
            [state] => on
            [img_type] => dimmer_on
        )

@ghosmar

This comment has been minimized.

Copy link
Author

commented Dec 18, 2013

btw. I like the new graphics 👍

@soif

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2013

Excellent!
It seems OK to release a the new version. So we will see what other people report!

Thank you VERY much for your reports! It really help me a lot!

@soif soif closed this Dec 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.