This repository has been archived by the owner on Mar 6, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed there was a problem when an argument was a string containing a comma:
The argument count was off because the comma was interpreted as an argument separator.
So I tried to look around for examples on uncommon cases that might not been handled: nested calls, multiline arguments, etc.
I found some cases that was not handled so add a few more tests.
I try to explain my logic when it come to solving the issues in the commit message, don't hesitate to check it out.
There one case that might be a personal preference and I don't know how it should behave.
So any one reading this, please gave us your opinion so we can try to choose the more commonly accepted behavior:
<>
being the cursor position when we ask for the signature to be resolved.I personally expect to have this result:
But I get that it can be confusing since:
Would resolved as:
I guess it can be sum up to, would you gave the priority to resolve the signature of: