Gh 1660 (#1661)

* Failing test * Fix missing key
phpactor · May 26, 2022 · ed4d3c4 · ed4d3c4
1 parent c607643
commit ed4d3c4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/lib/WorseReflection/Core/Inference/Resolver/AssignmentExpressionResolver.php b/lib/WorseReflection/Core/Inference/Resolver/AssignmentExpressionResolver.php
@@ -27,6 +27,7 @@
 use Phpactor\WorseReflection\Core\Type\AggregateType;
 use Phpactor\WorseReflection\Core\Type\ArrayLiteral;
 use Phpactor\WorseReflection\Core\Type\ArrayShapeType;
+use Phpactor\WorseReflection\Core\Type\ArrayType;
 use Phpactor\WorseReflection\Core\Type\Literal;
 use Phpactor\WorseReflection\Core\Type\MissingType;
 use Phpactor\WorseReflection\Core\Type\StringType;
@@ -170,6 +171,11 @@ private function walkSubscriptExpression(NodeContextResolver $resolver, Frame $f
                     $accessType = $resolver->resolveNode($frame, $leftOperand->accessExpression)->type();
 
                     if (!$accessType instanceof Literal) {
+                        $frame->locals()->add(
+                            $variable->withType(
+                                new ArrayType(TypeFactory::undefined(), $rightContext->type())
+                            )
+                        );
                         return;
                     }
 
@@ -209,7 +215,7 @@ private function hasMissingTokens(AssignmentExpression $node): bool
                 return true;
             }
         }
-        
+
         return false;
     }
 
@@ -223,18 +229,18 @@ private function walkArrayElements(array $elements, Node $leftOperand, Type $typ
             if (!$element instanceof ArrayElement) {
                 continue;
             }
-        
+
             $index++;
             $elementValue = $element->elementValue;
             if (!$elementValue instanceof Variable) {
                 continue;
             }
-        
+
             /** @phpstan-ignore-next-line */
             if (null === $elementValue || null === $elementValue->name) {
                 continue;
             }
-        
+
             $varName = NodeUtil::nameFromTokenOrNode($leftOperand, $elementValue->name);
 
             $variableContext = NodeContextFactory::create(

diff --git a/lib/WorseReflection/Tests/Inference/assignment/unknown_key.test b/lib/WorseReflection/Tests/Inference/assignment/unknown_key.test
@@ -0,0 +1,10 @@
+<?php
+
+
+$results = [];
+foreach ($this->analyser->analyse($input->getArgument(self::ARG_PATH)) as $file => $diagnostics) {
+    $results[$file] = 1234;
+}
+
+wrAssertType('array<<missing>,1234>', $results);
+