Field width 536870912 is too long

[BladeMF]

I keep getting this error for some reason:
Fatal error: Field width 536870912 is too long in /root/.shared_extensions/phpactor3/lib/WorseReflection/Core/Type/StringLiteralType.php on line 34

the code there is this:

        if ($right instanceof StringLiteralType) {
            return new self(sprintf('%s%s', $this->value, (string)$right->value()));
        }

[BladeMF]

Tried changing to:

return new self(sprintf('%1024s%1024s', $this->value, (string)$right->value()));

but no luck yet.

[BladeMF]

This saved me:

			return new self(sprintf(
				'%s%s',
				substr($this->value, 0, 1024),
				substr((string)$right->value(), 1024)
			));

[BladeMF]

Still not sure what caused it.

[dantleech]

Yes that should definitely have been truncated, there us little to no value in storing the contents if the string

[dantleech]

would you be willing to create a PR?

[BladeMF]

Sure, but I am not sure what the length should be. I am a bit overwhelmed at the moment - I've been putting off my PR about switches for enabling and disabling different language server services for a very long time now, but I hope in a couple of weeks I would be able to.

[dantleech]

no worries, but basically the length can be arbitrary, e.g. 255 chars, maybe adding ... if it's truncated

[BladeMF]

Sounds good.

[dantleech]

should be fixed as of #2200