-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inlay Hints showing in-between text in helix editor #2660
Comments
Probably because we provide the "start" position of the node: phpactor/lib/Extension/LanguageServerWorseReflection/InlayHint/InlayHintWalker.php Line 124 in ac99b4d
In Neovim the hints show to the right of the line regardless, which is why I haven't noticed this: I guess the issue is that the start poisition in your example is off by one? happy to accept an PR to fix the behavior. |
@Cyberphinx did this make it to issues? Also did u find any workaround this bug ? |
@zackAJ this is an issue? just FYI: I don't get this behavior when renaming and the inlay hints work fine for me in neovim... |
Well I don't have much going on in my config, pretty fresh installation (kickstart) + only phpactor as an lsp. What do you suggest, should I do to experiment around ? |
Restarting VIM but assume you did that, how did you install Phpactor? |
Client via Mason, and then added minimal setup function to my config. |
The inlay hints are now in correct position when opening the same file in neovim (NVIM v0.11.0-dev) with below lsp config for phpactor. Interestingly, after closing neovim and re-opening helix, the inlay hints appear in correct position in helix.
|
Same problem here. Installed via Mason in v0.10.0 neovim. |
I still have the problem in Installed via Mason in v0.10.0 Neovim, tried the following configs: phpactor = {
cmd = { "phpactor", "language-server" },
filetypes = { "php" },
settings = {
phpactor = {
language_server_phpstan = { enabled = false },
language_server_psalm = { enabled = false },
},
},
} phpactor = {
cmd = { "phpactor", "language-server" },
filetypes = { "php" },
settings = {
phpactor = {
language_server_phpstan = { enabled = true },
language_server_psalm = { enabled = true },
},
},
} phpactor = {
cmd = { "phpactor", "language-server" },
filetypes = { "php" },
settings = {
phpactor = {
language_server_phpstan = { enabled = true },
language_server_psalm = { enabled = true },
inlayHints = {
enable = true,
parameterHints = true,
typeHints = true,
},
},
},
} |
This issues has appeared again after updating/reinstalling php8.2 and some extensions, such as xmlwriter/simplexml. |
you mean the issue went away and came back? |
Yes it went away and came back |
phpactor version: Phpactor 2024.03.09.0@92eb89603c1af3e7b55cedc34ea70945dbfaec0a
operating system: Ubuntu 22.04.4 LTS
code editor: Helix
terminal: Alacritty
shell: Fish
terminal multiplexer: Zellij
project: Laravel app
.phpactor.json:
phpactor status:
helix lsp configuration:
issue: the inlay hints are appearing in-between the first character of a text and the rest of the text from its second character.
The text was updated successfully, but these errors were encountered: