Inlay Hints showing in-between text in helix editor

[Cyberphinx]

phpactor version: Phpactor 2024.03.09.0@92eb89603c1af3e7b55cedc34ea70945dbfaec0a
operating system: Ubuntu 22.04.4 LTS
code editor: Helix
terminal: Alacritty
shell: Fish
terminal multiplexer: Zellij
project: Laravel app
.phpactor.json:

{
    "language_server_worse_reflection.inlay_hints.enable": true,
    "language_server_worse_reflection.inlay_hints.types": true,
    "language_server_worse_reflection.inlay_hints.params": true,
    "language_server_phpstan.enabled": true,
    "php_code_sniffer.enabled": true
}

phpactor status:

Version: 2024.03.09.0
Filesystems: git, simple, composer
Working directory: /home/user/sites/website

Config files (missing is not bad):

  ✘ /home/user/.config/phpactor/phpactor.json
  ✘ /home/user/.config/phpactor/phpactor.yml
  ✔ /home/user/sites/sta-supplies-ltd/.phpactor.json
  ✘ /home/user/sites/sta-supplies-ltd/.phpactor.yml

Diagnostics:

  ✔ Composer detected - Phpactor could work faster without an index
  ✔ Git detected - enables faster refactorings in your repository scope!
  ✔ XDebug is disabled. XDebug has a negative effect on performance.

helix lsp configuration:

Configured language servers:
  ✓ intelephense: /usr/local/bin/intelephense
  ✓ phpactor: /home/user/.local/bin/phpactor
  ✓ efm-langserver: /usr/bin/efm-langserver
  ✓ tailwindcss-language-server: /usr/local/bin/tailwindcss-language-server
Configured debug adapter: None
Configured formatter: None
Highlight queries: ✓
Textobject queries: ✓
Indent queries: ✓

issue: the inlay hints are appearing in-between the first character of a text and the rest of the text from its second character.

[dantleech]

Probably because we provide the "start" position of the node:

phpactor/lib/Extension/LanguageServerWorseReflection/InlayHint/InlayHintWalker.php

Line 124 in ac99b4d

position: PositionConverter::intByteOffsetToPosition($node->getStartPosition(), $node->getFileContents()),

In Neovim the hints show to the right of the line regardless, which is why I haven't noticed this:

I guess the issue is that the start poisition in your example is off by one?

happy to accept an PR to fix the behavior.

[zackAJ]

This should be an issue
same problem here, using neovim, always off by one position but not just that:
when renaming a symbol it renames it with the off selection

[zackAJ]

@Cyberphinx did this make it to issues? Also did u find any workaround this bug ?

[dantleech]

@zackAJ this is an issue? just FYI: I don't get this behavior when renaming and the inlay hints work fine for me in neovim...

[zackAJ]

@zackAJ this is an issue? just FYI: I don't get this behavior when renaming and the inlay hints work fine for me in neovim...

Well I don't have much going on in my config, pretty fresh installation (kickstart) + only phpactor as an lsp.

What do you suggest, should I do to experiment around ?

[dantleech]

Restarting VIM but assume you did that, how did you install Phpactor?

[zackAJ]

Restarting VIM but assume you did that, how did you install Phpactor?

Client via Mason, and then added minimal setup function to my config.

[Cyberphinx]

The inlay hints are now in correct position when opening the same file in neovim (NVIM v0.11.0-dev) with below lsp config for phpactor. Interestingly, after closing neovim and re-opening helix, the inlay hints appear in correct position in helix.

phpactor = {
          settings = {
            phpactor = {
              inlayHints = {
                enable = true,
                parameterHints = true,
                typeHints = true,
              },
            },
          },
        },

[scippio]

Same problem here. Installed via Mason in v0.10.0 neovim.

[zackAJ]

I still have the problem in Installed via Mason in v0.10.0 Neovim, tried the following configs:

phpactor = {
	cmd = { "phpactor", "language-server" },
	filetypes = { "php" },
	settings = {
		phpactor = {
			language_server_phpstan = { enabled = false },
			language_server_psalm = { enabled = false },
		},
	},
}

phpactor = {
	cmd = { "phpactor", "language-server" },
	filetypes = { "php" },
	settings = {
		phpactor = {
			language_server_phpstan = { enabled = true },
			language_server_psalm = { enabled = true },
		},
	},
}

phpactor = {
	cmd = { "phpactor", "language-server" },
	filetypes = { "php" },
	settings = {
		phpactor = {
			language_server_phpstan = { enabled = true },
			language_server_psalm = { enabled = true },
			inlayHints = {
				enable = true,
				parameterHints = true,
				typeHints = true,
			},
		},
	},
}

---

[Cyberphinx]

This issues has appeared again after updating/reinstalling php8.2 and some extensions, such as xmlwriter/simplexml.

[dantleech]

you mean the issue went away and came back?

[Cyberphinx]

you mean the issue went away and came back?

Yes it went away and came back