Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Additional Text Edits support for class import #607

Closed
dantleech opened this issue Oct 3, 2018 · 0 comments
Closed

[LSP] Additional Text Edits support for class import #607

dantleech opened this issue Oct 3, 2018 · 0 comments

Comments

@dantleech
Copy link
Collaborator

It should be relatively simply to support additional text edits, to support with the neovim_LanguageClient

  • The primary suggestion must be a TextEdit (with the correct start and end offsets). Wil need to support returning the start position in the completion library.
  • The new suggestion's (line) position should be offset by any additional edits,
  • We can probably build a bridge for the existing TextEditBuilder to support returning TextEdit instances.

This feature may incur a performance penalty (e.g. it has to calculate the import edits for each importable suggestion). So it should be configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant