Self destruct #1604
Merged
Self destruct #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
gh-1599-self-destruct
branch
from
078ce93
to
673b9c0
Compare
dantleech
force-pushed
the
gh-1599-self-destruct
branch
from
673b9c0
to
ca41df8
Compare
|
|
||
|
|
||
|
|
||
| Amount of time to wait before responding to a shutdown notification |
There was a problem hiding this comment.
It would be good to add time units to both descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will self destruct if no exit notification recieved after 2.5 seconds fixes #1599