Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add laravel extension #1991

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

Add laravel extension #1991

wants to merge 62 commits into from

Conversation

haringsrob
Copy link
Contributor

@haringsrob haringsrob commented Dec 20, 2022

This pr adds Laravel tooling using the extractor in github.com/haringsrob/laravel-dev-tools

  • Service container make
  • Route autocomplete route('<>')
  • View autocomplete view('<>')
  • Model properties
  • Model relations

@dantleech
Copy link
Collaborator

dantleech commented Dec 20, 2022

nice, feel free to concentrate on one feature at a time, that way we can ensure we're adding the necessary tests etc. plus we can merge quicker...

@haringsrob
Copy link
Contributor Author

hey @dantleech I am about to pick this back up.

Regarding the external binary. It is for sure doable without I guess, but for me it would be more difficult at this point as I simply am not known enough to the phpactor codebase. Can keep using it for now?

Also, maybe I better split this work into a separate extension if that is still a possibility? Some thing I for sure need to do in the future is to have the ability to inject types into a file (see #1807)

Waiting for your advice.

@haringsrob haringsrob marked this pull request as ready for review April 17, 2023 18:51
@haringsrob
Copy link
Contributor Author

Lot's of progress was made, may want to add some tests as well so I can avoid myself from breaking but also add failing tests for things I expect to work :), this however, would need a full laravel installation to work with, any suggestions?

@haringsrob haringsrob changed the title [WIP] Add laravel extension Add laravel extension Apr 17, 2023
@@ -30,7 +30,8 @@
"phpactor/tolerant-php-parser": "dev-main",
"phpactor/map-resolver": "^1.5.0",
"webmozart/assert": "^1.11",
"webmozart/path-util": "^2.3"
"webmozart/path-util": "^2.3",
"illuminate/view": "^8.83"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I refactored this out already so no need anymore I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in fact needed as I managed to use fully compiled blade for lsp resolving using a slightly modified compiler.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really feel comfortable depending on having a hard dependency on a framework component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure i can copy just the needed parts over without all the rest

@dantleech
Copy link
Collaborator

dantleech commented Apr 29, 2023

impressive work so far 🎉 but please note that this branch should be treated as an experiment, it will be very difficult to review / merge this as it is, we should start creating PRs offering one feature at a time (or at least PRs that are of a small enough size). Any change to the Phpactor internals should be offered separately in individual PRs.

@haringsrob
Copy link
Contributor Author

impressive work so far 🎉 but please note that this branch should be treated as an experiment, it will be very difficult to review / merge this as it is, we should start creating PRs offering one feature at a time (or at least PRs that are of a small enough size). Any change to the Phpactor internals should be offered separately in individual PRs.

Yes totally agree. It is however very hard to see of things work if I would have contributed smaller parts. I think one I have worked with it for a few weeks and things are stable I can start making pr's with tests of smaller chunks

@vivere-dally
Copy link

Hello! Sorry for bothering, but are there any updates on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants