Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 2320: Add passing test #2324

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Gh 2320: Add passing test #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8e5982
Add failing test
dantleech Jul 16, 2023
19c66b1
Better failure message
dantleech Jul 16, 2023
42b2d00
Made byteoffsetrange strinable
dantleech Jul 16, 2023
b2fdae7
Add test case
dantleech Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/Extension/WorseReflection/Tests/Example/DiagnosticsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ public function testDiagnostics(DiagnosticProvider $provider, DiagnosticExample
}

if ($example->valid) {
if (count($diagnostics) > 1) {
self::fail(sprintf("Expected code to be valid but recieved diagnostics: \n%s", $diagnostics->__toString()));
}
self::assertCount(0, $diagnostics);
return;
}
Expand Down
9 changes: 8 additions & 1 deletion lib/TextDocument/ByteOffsetRange.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

namespace Phpactor\TextDocument;

class ByteOffsetRange
use Stringable;

class ByteOffsetRange implements Stringable
{
public function __construct(private ByteOffset $start, private ByteOffset $end)
{
Expand Down Expand Up @@ -30,4 +32,9 @@ public function end(): ByteOffset
{
return $this->end;
}

public function __toString(): string
{
return sprintf('%s-%s', $this->start->toInt(), $this->end->toInt());
}
}
14 changes: 14 additions & 0 deletions lib/WorseReflection/Bridge/TolerantParser/Diagnostics/UndefinedVariableProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,20 @@ function foo(): void
Assert::assertCount(0, $diagnostics);
}
);
yield new DiagnosticExample(
title: 'variable captured by closure',
source: <<<'PHP'
<?php
$classFqns = ['string'];
function (string $classFqn) use (&$classFqns): string {
$classFqns[] = 'boo';
}
PHP,
valid: true,
assertion: function (Diagnostics $diagnostics): void {
Assert::assertCount(0, $diagnostics);
}
);
}

public function enter(NodeContextResolver $resolver, Frame $frame, Node $node): iterable
Expand Down
2 changes: 1 addition & 1 deletion lib/WorseReflection/Core/Diagnostics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct(private array $diagnostics)
public function __toString(): string
{
return implode("\n", array_map(function (Diagnostic $diagnostic) {
return sprintf('[%s] %s', $diagnostic->severity()->toString(), $diagnostic->message());
return sprintf('[%s] %s (%s))', $diagnostic->severity()->toString(), $diagnostic->message(), $diagnostic->range()->__toString());
}, $this->diagnostics));
}

Expand Down
Loading