Generate @param for iterable type
#2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
commented
Aug 19, 2023
...eTransform/Tests/Adapter/WorseReflection/Transformer/UpdateDocblockReturnTransformerTest.php
Outdated
Show resolved
Hide resolved
Comment on lines
+76
to
+80
| if ($claimedReturnType->isDefined() | ||
| && !$claimedReturnType->isClass() | ||
| && !$claimedReturnType->isArray() | ||
| && !$claimedReturnType->isClosure() | ||
| && !$claimedReturnType->isIterable() |
There was a problem hiding this comment.
It would probably be easier to list the cases where it's true. Like scalar types?
dantleech
approved these changes
Aug 22, 2023
|
thanks! although I'm not sure what the original issue was as it was only a truncated screenshot. Probably this is the fix 😅 |
|
The problem was that if you're function return type was iterable it didn't suggest generating a docblock for the specific type. Like it does with arrays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2084