Generate methods on enum #2416
Merged
Generate methods on enum #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
generate_methods_on_enum
branch
from
e0f336a
to
2d8b011
Compare
|
nice 🙂 can you add a test to see if it breaks backed enums? |
|
Added a test of breaking enums. It breaks different than I expected it to break. And as for the 8.0 phpunit. I don't know why they work differently than the other ones. Does it have anything to do with the enums not being fully supported yet in that version? |
|
probably, you need to skip enum support for 8.0 |
mamazu
force-pushed
the
generate_methods_on_enum
branch
from
482579a
to
5435bd9
Compare
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2409
Adds the ability to generate methods on enum classes if they don't exist. In the process of implementing the feature I found out that phpactor doesn't have a code builder for enum classes which I added. However, the code builder only supports non-backed enums and might break enums that are backed. I'm not sure this is a requirement though or if I should just throw an error if the enum is backed and don't do anything.