Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly class attributes #2493

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Readonly class attributes #2493

merged 6 commits into from
Jan 6, 2024

Conversation

dantleech
Copy link
Collaborator

@dantleech dantleech commented Jan 6, 2024

Fixes the parser bug in our TP fork, updates the fork and also pushes fix upstream microsoft/tolerant-php-parser#409. Fixes #2487

Relevsnt CL:

  jetbrains/phpstorm-stubs 18580146..50172be1

    [2023-12-04 09:14:39] 1df0a978 cookieguru Add additional documentation to BackedEnum methods
    [2023-11-28 08:44:50] 5ac37090 isfedorov [phpstorm-stubs] update docker images to php 8.3
    [2023-11-28 09:43:08] 2be4232f isfedorov Revert "[phpstorm-stubs] update CHAR_MAX constant value"  This reverts commit 295a9901918...
    [2023-12-15 18:41:03] c4c34f19 isfedorov [phpstorm-stubs] update composer requirements
    [2023-12-15 19:07:14] 0ed9bb72 isfedorov [phpstorm-stubs] update testClassesReadonly test
    [2023-12-15 19:38:47] 06af30fa isfedorov [phpstorm-stubs] update cs-fixer config
    [2023-12-15 19:42:51] 92dda011 isfedorov [phpstorm-stubs] fix cs-fixer errors
    [2023-12-21 13:57:21] 50172be1 ondrejmirtes BackedEnum::from() can also throw TypeError

  phpactor/tolerant-php-parser 41b24b0c..bdc70091

    [2022-09-22 12:52:08] ce5acf31 TysonAndre Use PHPDoc `@param string ...$classNames`  The `string` is the type of each argument. Th...
    [2023-01-08 09:59:35] be9371d4 dantleech Remove TODO
    [2023-01-08 10:06:08] 539b8c34 dantleech Improve comment
    [2023-04-20 20:41:43] b53236e6 dantleech Add testes
    [2023-04-20 20:41:50] 4bbff613 dantleech Add extra nodes
    [2023-04-20 20:43:33] 1a59cc2a dantleech Add interface clause
    [2023-05-16 08:41:43] 0772bfa6 zobo fix: Allow getResolvedName to resolve QualifiedName in TraitUseClause
    [2023-05-16 23:37:24] 57e78ca3 zobo Add tests to check for trait QualifiedName resolving
    [2023-05-30 16:27:18] 981d92be sytranvn Update HowItWorks.md
    [2023-05-30 16:27:37] 16c1c13b sytranvn Update Overview.md
    [2023-06-07 01:14:33] 70a5e438 microsoft-github-policy-service[bot] Microsoft mandatory file
    [2024-01-06 17:46:21] 7d843d24 dantleech Fix conflicts
    [2024-01-06 17:54:12] bdc70091 dantleech bugfix: Support attributes on readonly classes

@dantleech dantleech merged commit fabdcdc into master Jan 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attributes of readonly classes are not recognized
2 participants