Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2538: Fix for diagnostic/linting concurrency. #2558

Closed
wants to merge 1 commit into from

Conversation

dantleech
Copy link
Collaborator

@dantleech dantleech commented Feb 24, 2024

Hopefully fixes #2538

This PR will:

  • Fix a wrong assumption that the text document version should b e provided on save by the client. We now get the last known version from the Workspace.
  • Do not run the linters if the text document (which may have been queued) is older than the last linted version of that document.

@dantleech dantleech changed the title Udpate composer and try and fix GH-2538 GH-2538: Fix for diagnostic/linting concurrency. Feb 24, 2024
@artfulrobot
Copy link

Tried this. With mason in neovim, I still get several processes: one for each file I have open in nvim and another one.

image

@dantleech
Copy link
Collaborator Author

dantleech commented Feb 28, 2024

I still get several processes: one for each file I have open in nvim and another one.

it's still expected to get one per file - has this PR improved it at all? I guess even if we throttled it to one file you'd still be waiting for it to analyze the open files.

this PR should prevent having > 1 process running per-file unnecessarily.

i'm going to check the example given in the original issue and see if I can see what could make the diagnostics so slow.

@dantleech
Copy link
Collaborator Author

this has made it into master now anyway, so closing.

@dantleech dantleech closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phpactor is killing my cpu
2 participants