Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2438: Bump langauge server to improve engine #2584

Merged
merged 4 commits into from
Mar 9, 2024
Merged

GH-2438: Bump langauge server to improve engine #2584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4a5f26
Bump langauge server to improve engine
dantleech Mar 3, 2024
d8be19b
Buimp again
dantleech Mar 3, 2024
e27ee6c
Add passing test for possibly falase
dantleech Mar 9, 2024
dc47d73
Fix tests
dantleech Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Improvements:
it has massive performance impact on certain projects #2580
- Include project PHP and runtime version and LSP status
- Add `iterable` "generic" `@param` in docblock #2585
- Improved diagnostic engine #2584

Bug fixes:

Expand All @@ -32,7 +33,6 @@ Bug fixes:
- Upgrade `amp/process` to fix #2516 thanks to @gerardroche
- Fix division by zero edge case
- Fix crash if referenced file no longer exists on class rename #2518
- Fix diagnostic process concurrency and do not lint outdated files #2538
- Fix detection of import used relatively in an annotation #2539
- Fix PHAR crashing issue on PHP8.3 #2533
- Fix UTF-16 conversion for LSP #2530 #2557
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"amphp/process": "^1.1.5",
"thecodingmachine/safe": "^1.0",
"phpactor/phly-event-dispatcher": "^2.0.0",
"phpactor/language-server": "^6.1.1",
"phpactor/language-server": "dev-master",
"phpactor/language-server-protocol": "^3.17.3",
"dantleech/object-renderer": "^0.1.1",
"monolog/monolog": "^1.23",
Expand Down
176 changes: 89 additions & 87 deletions composer.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/Extension/LanguageServerCodeTransform/Tests/Unit/CodeAction/CreateClassProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public function provideClassCreateProvider(): Generator
// File: subject.php

EOT
, 4, 1
, 4, 0
];

yield 'non empty file' => [
Expand Down
1 change: 1 addition & 0 deletions lib/Extension/LanguageServerCodeTransform/Tests/Unit/CodeAction/ImportNameProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ public function testImportProvider(string $manifest, Closure $assertion, bool $i

$transmitter = $tester->transmitter()->filterByMethod('textDocument/publishDiagnostics');
$diagnostics = $transmitter->shiftNotification();
$diagnostics = $transmitter->shiftNotification();
$diagnostics = $diagnostics->params['diagnostics'] ?? [];
$assertion($result->result, $diagnostics);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/Extension/LanguageServerPhpstan/Tests/Provider/PhpstanDiagnosticProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function testHandleSingle(): void

wait(delay(10));

self::assertEquals(1, $this->tester->transmitter()->count());
self::assertEquals(2, $this->tester->transmitter()->count());
}

private function createTestLinter(): TestLinter
Expand Down
2 changes: 1 addition & 1 deletion lib/Extension/LanguageServerPsalm/Tests/DiagnosticProvider/PsalmDiagnosticProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function testHandleSingle(): void

wait(delay(10));

self::assertEquals(1, $this->tester->transmitter()->count());
self::assertEquals(2, $this->tester->transmitter()->count());
}

private function createTestLinter(): TestLinter
Expand Down
3 changes: 1 addition & 2 deletions lib/WorseReflection/Tests/Inference/type/false.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

namespace Foo;

wrAssertType('string|false', possiblyFalse());

function possiblyFalse(array $foo): string|false
{
}
Expand All @@ -16,3 +14,4 @@ function date()
}

wrAssertType('string|false', date());
wrAssertType('string|false', possiblyFalse());