fix: interfaces, traits, enums and final classes can not be abstract (#…

…425)
phparkitect · May 8, 2024 · f55131c · f55131c
1 parent b1f0560
commit f55131c
Show file tree

Hide file tree

Showing 2 changed files with 86 additions and 1 deletion.
diff --git a/src/Expression/ForClasses/IsAbstract.php b/src/Expression/ForClasses/IsAbstract.php
@@ -20,7 +20,8 @@ public function describe(ClassDescription $theClass, string $because): Descripti
 
     public function evaluate(ClassDescription $theClass, Violations $violations, string $because): void
     {
-        if ($theClass->isAbstract()) {
+        if ($theClass->isAbstract() || $theClass->isInterface() || $theClass->isTrait() || $theClass->isEnum()
+            || $theClass->isFinal()) {
             return;
         }
 

diff --git a/tests/Unit/Expressions/ForClasses/IsAbstractTest.php b/tests/Unit/Expressions/ForClasses/IsAbstractTest.php
@@ -57,4 +57,88 @@ public function test_it_should_return_true_if_is_abstract(): void
         $isAbstract->evaluate($classDescription, $violations, $because);
         self::assertEquals(0, $violations->count());
     }
+
+    public function test_interfaces_can_not_be_abstract_and_should_be_ignored(): void
+    {
+        $isAbstract = new IsAbstract();
+        $classDescription = new ClassDescription(
+            FullyQualifiedClassName::fromString('HappyIsland'),
+            [],
+            [],
+            null,
+            false,
+            false,
+            false,
+            true,
+            false,
+            false
+        );
+        $because = 'we want to add this rule for our software';
+        $violations = new Violations();
+        $isAbstract->evaluate($classDescription, $violations, $because);
+        self::assertEquals(0, $violations->count());
+    }
+
+    public function test_traits_can_not_be_abstract_and_should_be_ignored(): void
+    {
+        $isAbstract = new IsAbstract();
+        $classDescription = new ClassDescription(
+            FullyQualifiedClassName::fromString('HappyIsland'),
+            [],
+            [],
+            null,
+            false,
+            false,
+            false,
+            false,
+            true,
+            false
+        );
+        $because = 'we want to add this rule for our software';
+        $violations = new Violations();
+        $isAbstract->evaluate($classDescription, $violations, $because);
+        self::assertEquals(0, $violations->count());
+    }
+
+    public function test_enums_can_not_be_abstract_and_should_be_ignored(): void
+    {
+        $isAbstract = new IsAbstract();
+        $classDescription = new ClassDescription(
+            FullyQualifiedClassName::fromString('HappyIsland'),
+            [],
+            [],
+            null,
+            false,
+            false,
+            false,
+            false,
+            false,
+            true
+        );
+        $because = 'we want to add this rule for our software';
+        $violations = new Violations();
+        $isAbstract->evaluate($classDescription, $violations, $because);
+        self::assertEquals(0, $violations->count());
+    }
+
+    public function test_final_classes_can_not_be_abstract_and_should_be_ignored(): void
+    {
+        $isAbstract = new IsAbstract();
+        $classDescription = new ClassDescription(
+            FullyQualifiedClassName::fromString('HappyIsland'),
+            [],
+            [],
+            null,
+            true,
+            false,
+            false,
+            false,
+            false,
+            false
+        );
+        $because = 'we want to add this rule for our software';
+        $violations = new Violations();
+        $isAbstract->evaluate($classDescription, $violations, $because);
+        self::assertEquals(0, $violations->count());
+    }
 }