Added docs for js linting #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure where we would add this, but I guess it would certainly help developers with having proper hinting in PhpStorm: http://rst.ninjs.org/?n=cedca49250c539685ff0dd39bec7fe4e&theme=basic |
|
Would probably be best to just send it to people if they complain. It's not related to this PR because it's already an issue. |
|
yeah, I'm with callum. Specific stuff should not be here. Feel free to add a doc how to set up phpStorm properly with everything (php libs, js libs, root dir, exclude vendor, ...). But not here. |
|
Probably worth doing, if they're still giving us a free license |
|
Well definitely not in the coding guidelines. Just pointing out that we might want to add that somewhere in the documentation. |
|
👍 |
nickvergessen
added a commit
that referenced
this pull request
May 31, 2015
Added docs for js linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpbb/phpbb#3668