Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests purge cache before running. (develop) #1070

Merged
merged 1 commit into from Nov 15, 2012

Conversation

Fyorl
Copy link
Contributor

@Fyorl Fyorl commented Nov 11, 2012

@igorw
Copy link
Contributor

igorw commented Nov 12, 2012

I'm assuming this requires #1069 to be merged. It will not work, because the cache classes are different in 3.1. You need to create the cache driver instead of the cache class, and the includes will need to go away since those classes are autoloaded.

Can you make this PR include the commits from #1069 and then apply the changes I mentioned on top of them?

@Fyorl
Copy link
Contributor Author

Fyorl commented Nov 13, 2012

It doesn't require #1069 to be merged. In #1069 I write my own purge_cache method and get_cache_driver because they do not exist in the test framework in develop-olympus. In develop there is already a get_cache_driver and purge_cache function that uses the new cache and so I just call the already-available purge_cache here.

@igorw
Copy link
Contributor

igorw commented Nov 13, 2012

Missed that part, thanks for clarifying.

p added a commit to p/phpbb3 that referenced this pull request Nov 15, 2012
* Fyorl/ticket/11190-develop:
  [ticket/11190-develop] Functional tests purge cache before running.
@p p merged commit db0cc74 into phpbb:develop Nov 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants