[ticket/11192] Add Tebibyte to get_formatted_filesize(). #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wat |
|
Was this tested on 32 bit php? Regression test please. |
PHPBB3-11192
| */ | ||
| public function test_get_formatted_filesize_string($input, $expected) | ||
| { | ||
| $output = get_formatted_filesize("$input"); |
| { | ||
| return array( | ||
| // exact powers of 2 | ||
| array(1, '1 BYTES'), |
There was a problem hiding this comment.
BYTES should be singular, same thing below.
There was a problem hiding this comment.
unrelated? there is no such language variable right now. maybe the function should use $user->lang()
There was a problem hiding this comment.
It does, if $user is set up, which for this test it isn't.
There was a problem hiding this comment.
It doesn't call the lang function, it does an array lookup.
There was a problem hiding this comment.
OK, it's fine with me either way, do you want to change anything?
… now. PHPBB3-11192
p
added a commit
to p/phpbb3
that referenced
this pull request
Nov 16, 2012
* bantu/ticket/11192: [ticket/11192] Merge dataProvider arrays because the test is the same now. [ticket/11192] Update $value parameter description to support other types. [ticket/11192] Mark negative byte numbers as unsupported. [ticket/11192] Test strings not converted to int/float before. [ticket/11192] Also test strings, e.g. sums returned by the database. [ticket/11192] Also test powers of 10 / 1000. [ticket/11192] Add tests. [ticket/11192] Add Tebibyte to get_formatted_filesize().
p
added a commit
to p/phpbb3
that referenced
this pull request
Nov 16, 2012
* develop-olympus: [ticket/11192] Merge dataProvider arrays because the test is the same now. [ticket/11192] Update $value parameter description to support other types. [ticket/11192] Mark negative byte numbers as unsupported. [ticket/11192] Test strings not converted to int/float before. [ticket/11192] Also test strings, e.g. sums returned by the database. [ticket/11192] Also test powers of 10 / 1000. [ticket/11192] Add tests. [ticket/11192] Add Tebibyte to get_formatted_filesize().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPBB3-11192
http://tracker.phpbb.com/browse/PHPBB3-11192