Ticket/11174 more tests for search backends #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when running tests include utf_tools file in the mysql search backend PHPBB3-11174
PHPBB3-11174
native wrapper class is limited to the native search backend hence renamed. the one used with mysql can be used with pgsql too. PHPBB3-11174
PHPBB3-11174
set config values and use min length as 4 for wordss in test cases PHPBB3-11174
negation queries are split into words too and returns false in mysql search backend PHPBB3-11174
PHPBB3-11174
PHPBB3-11174
PHPBB3-11174
PHPBB3-11174
| parent::setUp(); | ||
|
|
||
| // dbal uses cache | ||
| $cache = new phpbb_cache_driver_null; |
There was a problem hiding this comment.
Isn't the global cache supposed be a cache service instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.phpbb.com/browse/PHPBB3-11174
Replaces #1080