[ticket/9983] Add redis cache driver tests. #1108
Conversation
In order to not overwrite data in default redis store, at least one of redis host or post must be explicitly specified. Redis cache driver constructor has been modified to accept host and port as parameters. This was not added to public API as there are more parameters being passed via global constants. PHPBB3-9983
| $db->sql_close(); | ||
| } | ||
|
|
||
| public function test_cache_sql_redis() |
There was a problem hiding this comment.
Those should probably go into different classes/files now.
There was a problem hiding this comment.
Add an abstract base class containing all the tests that all implementation are supposed to pass.
There was a problem hiding this comment.
The tests are not actually the same.
|
File count increased. |
|
No common tests in base class? Basic set/get test? |
PHPBB3-9983
PHPBB3-9983
PHPBB3-9983
PHPBB3-9983
|
Added more tests. |
| @@ -7,11 +7,12 @@ | |||
| * | |||
| */ | |||
|
|
|||
| require_once dirname(__FILE__) . '/../../phpBB/includes/functions.php'; | |||
| require_once dirname(__FILE__) . '/common_test_case.php'; | |||
There was a problem hiding this comment.
We currently have no autoloading for test related classes. But I'm not against adding it, perhaps in a separate PR.
There was a problem hiding this comment.
Oh, I thought tests already support it. In that case it's fine.
|
Unfortunately my distribution does not come with redis php bindings, so can not test this trivially. |
|
I don't think many do. I built the thing from source. |
| or port must be specified in test configuration. This can be done via | ||
| test_config.php as follows: | ||
|
|
||
| <? |
PHPBB3-9983
PHPBB3-9983
PHPBB3-9983
|
Fixed and added apc. Tried adding xcache but it was failing too much. |
|
https://gist.github.com/81423875ef085e6905ee scroll down for my conclusion. |
|
|
|
Merge p#34 |
In order to not overwrite data in default redis store, at least
one of redis host or post must be explicitly specified.
Redis cache driver constructor has been modified to accept
host and port as parameters. This was not added to public API
as there are more parameters being passed via global constants.
http://tracker.phpbb.com/browse/PHPBB3-9983