Ticket/11250 Remake the unit tests for the BBCode parser #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPBB3-11250
PHPBB3-11250
PHPBB3-11250
: . and [ are replaced by their html representation if they are text only PHPBB3-11250
…ones PHPBB3-11250
| { | ||
| if ($incomplete) | ||
| { | ||
| $this->markTestIncomplete('New bbcode parser has not been backported from feature/ascraeus-experiment yet.'); |
There was a problem hiding this comment.
You sure that this is text better than the personalized one? (like the one in line 240)
| array( | ||
| 'PHPBB3-9364 - quoted: "test[/[/b]quote] test" / non-quoted: "[/quote] test" - also failed if layout distorted', | ||
| '[quote]test[/[/b]quote] test [/quote][/quote] test', | ||
| '[quote:]test[/[/b]quote] test [/quote:][/quote] test', |
There was a problem hiding this comment.
Is this correct?
Specially the part:
test [/quote:][
There was a problem hiding this comment.
Yes this is how it should be, see the mentioned ticket in the description http://tracker.phpbb.com/browse/PHPBB3-9364
There was a problem hiding this comment.
sorry, misread how the uid works.
p
added a commit
to p/phpbb3
that referenced
this pull request
Dec 14, 2012
* nickvergessen/ticket/11250: [ticket/11250] Use user defined message as incomplete message [ticket/11250] Add tests for simple nesting and code [ticket/11250] Run tests by default and add an option for incomplete ones [ticket/11250] Fix parsing result with special chars [ticket/11250] Add tests for size and attachment [ticket/11250] Fix method names [ticket/11250] Add some comments and fix a description [ticket/11250] Add some more tests for quotes [ticket/11250] Move quote special cases from class to unit tests [ticket/11250] Add parsing tests for our basic bbcodes in simple cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some basic tests for 3.0 bbcodes and for the comments from message_parser.php
http://tracker.phpbb.com/browse/PHPBB3-11250