[ticket/11370] Effectively installed migrations not inserted into table #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insert_migration() function now handles inserting/updating Move all insert/update code to insert_migration() function to prevent this from occurring again. PHPBB3-11370
| @@ -669,12 +654,22 @@ protected function get_callable_from_step(array $step, $last_result = false, $re | |||
| protected function insert_migration($name, $state) | |||
There was a problem hiding this comment.
Could use a better function name here since it now also handles updates. set_migration_state() would be the natural choice,
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
insert_migration() function now handles inserting/updating
Move all insert/update code to insert_migration() function to prevent this from occurring again.
http://tracker.phpbb.com/browse/PHPBB3-11370