Ticket/10120 Make profiles publicly viewable by default #1351
Conversation
Give guests u_viewprofile permission. PHPBB3-10120
…ofiles. PHPBB3-10120
|
Replaces #412 |
| @@ -518,6 +522,18 @@ public function assertContainsLang($needle, $haystack, $message = null) | |||
| } | |||
|
|
|||
| /** | |||
| * assertNotContains for language strings | |||
There was a problem hiding this comment.
|
PR works for me and tests pass. |
|
Looks good. Should we change the behavior on update or only on new installs (as it is right now)? |
|
I dont think changing this behaviour on update will be the correct way? They may have their custom permissions settings. |
|
That makes sense. |
|
im with @dhruvgoel92 here |
|
What was the rationale behind restricting access for bots? If they're public, why try to prevent them from showing up in search engines? Any crawlers with bad intentions won't be stopped by this anyway. |
|
Guess I should have looked at area51 again: http://area51.phpbb.com/phpBB/viewtopic.php?f=81&t=35682 |
|
@dhruvgoel92 Btw before you merge something like this, make sure that it was actually decided on area51 properly ;-) |
|
As far as I can tell, the actual solution to the problem (namely hiding profiles of newly registered users from bots) has not been implemented, so this PR is at the very least incomplete if not incorrect. |
|
The reason i didnt implement that is, because we now have a permission for user profile fields. |
|
ah, @naderman I was missing that. I will make sure of it from now on. Thanks |
|
This really ought to be sorted out on Area51, someone needs to write down what all the options and opinions are and what can be done now. |
|
Please someone find or make a post on area51 with a complete specification of desired behavior and link from here. |
|
Will ABD until a decision is found |
http://tracker.phpbb.com/browse/PHPBB3-10120