Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/11537] Adjust error message on ucp group manage to fit rest of ucp #1406

Merged
merged 1 commit into from
May 19, 2013

Conversation

marc1706
Copy link
Member

The current look highly differed from the rest of the UCP. Additionally,
this caused the error message to be hardly noticeable at all.

Ticket: http://tracker.phpbb.com/browse/PHPBB3-11537

PHPBB3-11537

…f ucp

The current look highly differed from the rest of the UCP. Additionally,
this caused the error message to be hardly noticeable at all.

PHPBB3-11537
@marc1706
Copy link
Member Author

Yes, this fits the look on other pages, e.g. the registration details:
https://github.com/phpbb/phpbb3/blob/develop/phpBB/styles/prosilver/template/ucp_profile_reg_details.html#L13

@bantu
Copy link
Collaborator

bantu commented May 19, 2013

While this seems like quite an abuse of fieldset (no input, no dl, etc.), the HTML validator does not complain about it.

@bantu bantu merged commit 84cfacf into phpbb:develop-olympus May 19, 2013
@marc1706 marc1706 deleted the ticket/11537 branch May 19, 2013 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants