[ticket/8319] Prepend Board URL to LOCAL_URL links to prevent abuse #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description says: "The URL must be relative to the topic page and cannot contain a server name or protocol." We now enforce this and will add a new token with the current behaviour back. PHPBB3-8319
…L parts PHPBB3-8319
…update To fix http://tracker.phpbb.com/browse/PHPBB3-8319 we changed the second_pass_replace value, so that needs updating for existing ones. PHPBB3-8319
The explanation now states that links are prefixed with the board URL. PHPBB3-8319
| @@ -2204,6 +2204,36 @@ function change_database_data(&$no_updates, $version) | |||
| _sql($sql, $errored, $error_ary); | |||
| } | |||
|
|
|||
| /** | |||
| * Update BBCodes that currently use the LOCAL_URL tag | |||
There was a problem hiding this comment.
Shouldn't we adding this thing in migration data?
There was a problem hiding this comment.
@dhruvgoel92 This is olympus world. No migrations here.
There was a problem hiding this comment.
I guess I should create a second PR/Branch for Develop because of this?
|
Patch looks fine to me, aside from what I commented on, which isn't a big deal. |
|
Updated, develop version with migration: #1512 |
PHPBB3-8319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description says:
"The URL must be relative to the topic page and cannot contain a server name
or protocol."
We now enforce this and will added a new token RELATIVE_URL with the current behaviour.
Existing BBCodes are updated to the new replacement on update
http://tracker.phpbb.com/browse/PHPBB3-8319