[ticket/11608] add functional tests for search #1481
Conversation
|
|
||
| public function test_sphinx() | ||
| { | ||
| $this->markTestIncomplete('Sphinx search not running for the test board'); |
There was a problem hiding this comment.
Could be wrapped by if (class_exists('SphinxClient')) or not? Then the tests would run, when it is available?
There was a problem hiding this comment.
Also the message should then be something like "Did not run Sphinx Search Tests, as Sphinx is not installed"
There was a problem hiding this comment.
Also is this not catched by self::markTestSkipped("Search backend is not supported/running"); ?
|
please split things up into multiple files:
|
|
I have been unable to create tests for sphinx because sphinx indexer needs to be executed after we create index through acp. One possible way is to use exec ( ) but it is not recommended. If we cant come up with a solution rest of the tests should be merged IMO. |
| $crawler = self::request('GET', 'search.php?keywords=' . $keywords); | ||
| $this->assertEquals(0, $crawler->filter('.postbody')->count()); | ||
| $split_keywords_string = str_replace(array('+', '-'), ' ', $keywords); | ||
| $this->assertEquals($split_keywords_string, $crawler->filter('#keywords')->attr('value')); |
There was a problem hiding this comment.
This test currently passed only for mysql_fulltext.
There was a problem hiding this comment.
And it should also pass for Postgres, not tested it though :P
There was a problem hiding this comment.
Travis is passing for postgres fulltext. Sphinx test are skipped anyway, so I am thinking of fixing native_Search since it is the one which is failing
|
Please consider using |
| public function setUp() | ||
| { | ||
| parent::setUp(); | ||
| $this->search_backend = 'phpbb_search_fulltext_mysql'; |
There was a problem hiding this comment.
This seems to be a string that never changes. Remove this method and assign the string at variable definition?
|
Description says we are waiting for sphinx stuff here. Is this still the case? Please get this merge-ready without sphinx otherwise. |
|
Merge ready. #1054 needs to be merged before this PR as this includes test for that test case. |
|
Sphinx test fail... mark it as incomplete? |
|
Fixed. The failure in Postgres is fixed in #1054 |
| /** | ||
| * @group functional | ||
| */ | ||
| abstract class phpbb_functional_search_base_test extends phpbb_functional_test_case |
There was a problem hiding this comment.
should not end with testotherwise phpunit unneccessarily tries to run them
|
Fixed, can be merged now? |
|
Can this be rebased? |
PHPBB3-11608
PHPBB3-11608
Keyword search in search functional tests should be performed as guests rather than logged in as admin. PHPBB3-11608
Sphinx search for the test board cannot be tested PHPBB3-11608
Search tests check for highlighted words in search results PHPBB3-11608
Tests for each search backend are into their own separate files. These separate classes inherit from a common search test case class. PHPBB3-11608
Rename search_found and search_not_found to assert_search_found and assert_search_not_found. Count .errorbox incase the search backend is not supported and skip tests PHPBB3-11608
PHPBB3-11608
Rename base class to phpbb_functional_search_base and fix Docblocks as per phpbb guidelines. PHPBB3-11608
PHPBB3-11608
[ticket/11608] add functional tests for search
http://tracker.phpbb.com/browse/PHPBB3-11608
PHPBB3-11608