[WIP][ticket/11700] Namespaces #1565

naderman · 2013-07-14T17:33:30Z

http://tracker.phpbb.com/browse/PHPBB3-11700

…assname PHPBB3-11700

PHPBB3-11700

…n prefix PHPBB3-11700

PHPBB3-11700

nickvergessen · 2013-07-30T17:20:58Z

Status?

nickvergessen · 2013-09-10T13:12:53Z

phpBB/phpbb/db/migration/data/v310/dev.php

@@ -183,7 +185,7 @@ public function update_data()

 	public function move_customise_modules()
 	{
-		// Move language management to new location in the Customise tab
+		// Move language management to new \location in the Customise tab


naderman · 2013-09-10T14:18:29Z

Yeah, I'll merge develop when I got this working, and check it all again

naderman · 2013-09-10T14:18:41Z

Please don't review this, it's not done yet.

…faces PHPBB3-11700

PHPBB3-11700

* github-phpbb/develop: (586 commits) [ticket/11735] Display disabled checkbox in subsilver for read notifications [ticket/11735] Display disabled checkbox when notification is already read [ticket/11844] update acp/authentication language var [ticket/11795] Remove PM popup [ticket/11795] Remove outdated comment from forum_fn.js [ticket/11795] Move find user JS to forum_fn [ticket/11795] Replace TWIG with phpBB syntax in ACP [ticket/11795] Move MSN scripts to forum_fn.js [ticket/11795] Use phpBB template syntax instead of TWIG [ticket/11795] Move PM popup JS to forum_fn.js [ticket/11795] Get rid of pagination JS variables [ticket/11795] Get rid of onload_functions [ticket/11795] Use data-reset-on-edit attr to reset elements [ticket/11795] Redo form elements auto-focus [ticket/11811] Remove outline on :focus [ticket/11836] Fix subsilver fatal error [ticket/11837] Replace escaped single quote with utf-8 single quote [ticket/11836] Fix fatal error on unsupported provider for auth link [ticket/11837] Translate UCP_AUTH_LINK_NOT_SUPPORTED [ticket/11809] Ensure code.js is first script included after jQuery ... Conflicts: phpBB/config/services.yml phpBB/develop/create_schema_files.php phpBB/develop/mysql_upgrader.php phpBB/download/file.php phpBB/includes/bbcode.php phpBB/includes/functions_container.php phpBB/install/database_update.php phpBB/install/index.php phpBB/phpbb/controller/helper.php phpBB/phpbb/controller/resolver.php phpBB/phpbb/request/request_interface.php phpBB/phpbb/session.php phpBB/phpbb/style/extension_path_provider.php phpBB/phpbb/style/path_provider.php phpBB/phpbb/style/path_provider_interface.php phpBB/phpbb/style/resource_locator.php phpBB/phpbb/style/style.php phpBB/phpbb/template/locator.php phpBB/phpbb/template/template.php phpBB/phpbb/template/twig/node/includeasset.php phpBB/phpbb/template/twig/node/includecss.php phpBB/phpbb/template/twig/node/includejs.php phpBB/phpbb/template/twig/twig.php tests/controller/helper_url_test.php tests/di/create_container_test.php tests/extension/style_path_provider_test.php tests/notification/notification_test.php tests/session/continue_test.php tests/session/creation_test.php tests/template/template_events_test.php tests/template/template_test_case.php tests/template/template_test_case_with_tree.php tests/test_framework/phpbb_functional_test_case.php

PHPBB3-11700

imkingdavid · 2013-09-18T15:31:03Z

phpBB/common.php

-			new phpbb_request()
+	$phpbb_filesystem = new phpbb\filesystem(
+		new phpbb\symfony_request(
+			new phpbb\request\request()


Should these be prefixed with a back slash?

It's in non-namespaced code, so doesn't matter.

Should be consistent ideally. In this case with \phpbb\class_loader.

PHPBB3-11700

…equest is removed PHPBB3-11700

PHPBB3-11700

class loader now expects all classes to be prefixed with a backslash when resolving paths PHPBB3-11700

PHPBB3-11700

dhruvgoel92 · 2013-09-24T19:46:53Z

namespace migration didn't run at all for me. Also some migrations are being duplicated like phpbb\db\migration\data\30x\3_0_1_rc1 and \phpbb\db\migration\data\30x\3_0_1_rc1
We also need to update the config file during migration to change the $acm_type to use namespace or just file,null etc.

dhruvgoel92 · 2013-09-24T19:49:09Z

I tested the PR and it worked fine for me, tests pass and migration too worked apart from the comments :)

EXreaction · 2013-09-24T19:59:23Z

There should be a function that handles correcting the acm/sql type variables. Just update those functions appropriately, we don't really want to alter the file during updates as that becomes quite complex.

dhruvgoel92 · 2013-09-24T20:21:37Z

phpBB/phpbb/db/migration/data/v310/style_update_p2.php

@@ -16,7 +18,7 @@ public function effectively_installed()

 	static public function depends_on()
 	{
-		return array('phpbb_db_migration_data_310_style_update_p1');
+		return array('\phpbb\db\migration\data0\style_update_p1');


Typo this is why migrations dont run.

nickvergessen · 2013-09-24T20:31:19Z

Duplication is caused by dependencies.

They specify \ while the finder returns the version wihout leading \
So both are being added.

PHPBB3-11700

Ticket/naderman/11700

PHPBB3-11700

…talls PHPBB3-11700

[WIP][ticket/11700] Namespaces

naderman added 8 commits July 14, 2013 12:25

[ticket/11700] With namespaces interface will no longer be a valid cl…

b81613e

…assname PHPBB3-11700

[ticket/11700] Modify all code to use the new interface names

da2752e

PHPBB3-11700

[ticket/11700] Implement namespace loading in the class loader

d4d3d31

PHPBB3-11700

[ticket/11700] Instantiate the class loader with namespace rather tha…

4311cd6

…n prefix PHPBB3-11700

[ticket/11700] include and define are not valid class names

62b3396

PHPBB3-11700

[ticket/11700] Load namespaced classes in tests

3d45f69

PHPBB3-11700

[ticket/11700] Use a new style constructor for the error collector

adc58ba

PHPBB3-11700

[ticket/11700] Load the dbms with namespaces

b3e8734

PHPBB3-11700

nickvergessen reviewed Sep 10, 2013
View reviewed changes

naderman added 18 commits September 16, 2013 00:25

[ticket/11700] Add develop scripts to use namespaces and rename inter…

196e181

…faces PHPBB3-11700

[ticket/11700] Move all recent code to namespaces

b95fdac

PHPBB3-11700

[ticket/11700] Namespaces and class names should not start with digits

e1239b4

PHPBB3-11700

[ticket/11700] Fix number class names in 3.0.x migrations

ee73568

PHPBB3-11700

[ticket/11700] Fix avatar tests

43c5ed5

PHPBB3-11700

[ticket/11700] Fix config db tests after namespace mishap

1a6202d

PHPBB3-11700

[ticket/11700] Fix dbal tests after config namespace mishap

97012dd

PHPBB3-11700

[ticket/11700] Fix class loader tests for namespaces

76dfe15

PHPBB3-11700

[ticket/11700] Fix config namespace mishap in cache tests

e10c3d8

PHPBB3-11700

[ticket/11700] Fix expected class name output from dbms convert

239381b

PHPBB3-11700

[ticket/11700] Correclty use namespaces in notifications

2a1207b

PHPBB3-11700

[ticket/11700] Use underscores for generated search test wrappers

d122d84

PHPBB3-11700

[ticket/11700] Avoid \t in double quoted strings for template code

dc2f4a3

PHPBB3-11700

[ticket/11700] DI container test needs namespaces to work properly

9a2c29a

PHPBB3-11700

[ticket/11700] Get the installer to run with namespaces

d297eb4

PHPBB3-11700

[ticket/11700] Don't prefix dbms classnames with \

bdaf68c

PHPBB3-11700

[ticket/11700] Update finder tests for namespaced classnames

bb395bb

PHPBB3-11700

naderman added 3 commits September 17, 2013 18:18

[ticket/11700] Namespace needed for mock object in web path test

20b2d03

PHPBB3-11700

[ticket/11700] Namespacif skipped filesystem instantiation in test

1a92c04

PHPBB3-11700

[ticket/11700] Replace some leftover phpbb_filesystem uses

1adcbcc

PHPBB3-11700

imkingdavid reviewed Sep 18, 2013
View reviewed changes

naderman added 11 commits September 19, 2013 15:16

[ticket/11700] Add file headers to develop scripts for namespace

cc6f1e1

PHPBB3-11700

[ticket/11700] Fix some more incorrectly changed comments

06e7c84

PHPBB3-11700

[ticket/11700] Correctly handle avatar drivers with namespaces

15413f4

PHPBB3-11700

[ticket/11700] Correct ucp_auth_link request interface references

733020f

PHPBB3-11700

[ticket/11700] Correctly load avatar templates for namespaced drivers

40ea742

PHPBB3-11700

[ticket/11700] Fix redirection in common.php until fs dependency on r…

e998363

…equest is removed PHPBB3-11700

[ticket/11700] Change search backend db entry to namespaces

f205c4f

PHPBB3-11700

[ticket/11700] Fix extension loading with namespaces

fe36375

class loader now expects all classes to be prefixed with a backslash when resolving paths PHPBB3-11700

[ticket/11700] Get unit tests to run again with namespaces

16fdef4

PHPBB3-11700

[ticket/11700] Correctly load templates for extensions

6b71284

PHPBB3-11700

[ticket/11700] No need to escape \ in SQL string

1f9f969

PHPBB3-11700

dhruvgoel92 reviewed Sep 24, 2013
View reviewed changes

nickvergessen and others added 8 commits September 25, 2013 10:01

[ticket/11700] Fix unresolvable condition in migration

ed55626

PHPBB3-11700

[ticket/11700] Escape Backslashes from schema_data.sql for MySQLi

6254115

PHPBB3-11700

Merge pull request #3 from nickvergessen/ticket/naderman/11700

3209d3c

Ticket/naderman/11700

[ticket/11700] Return class names with leading backslash in finder

86147b4

PHPBB3-11700

[ticket/11700] Use spaces, not tabs

3a478cb

PHPBB3-11700

[ticket/11700] Only replace phpbb_search in strings that match

9373c0d

PHPBB3-11700

[ticket/11700] Update migrations table for namespaces

cbc458e

PHPBB3-11700

[ticket/11700] Undo migrations migration, as not an issue for new ins…

645bd12

…talls PHPBB3-11700

naderman added a commit that referenced this pull request Sep 25, 2013

Merge pull request #1565 from naderman/ticket/11700

8da3133

[WIP][ticket/11700] Namespaces

naderman merged commit 8da3133 into phpbb:develop Sep 25, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP][ticket/11700] Namespaces #1565

[WIP][ticket/11700] Namespaces #1565

naderman commented Jul 14, 2013

nickvergessen commented Jul 30, 2013

nickvergessen Sep 10, 2013

naderman commented Sep 10, 2013

naderman commented Sep 10, 2013

imkingdavid Sep 18, 2013

naderman Sep 19, 2013

bantu Sep 19, 2013

dhruvgoel92 commented Sep 24, 2013

dhruvgoel92 commented Sep 24, 2013

EXreaction commented Sep 24, 2013

dhruvgoel92 Sep 24, 2013

nickvergessen commented Sep 24, 2013

[WIP][ticket/11700] Namespaces #1565

[WIP][ticket/11700] Namespaces #1565

Conversation

naderman commented Jul 14, 2013

nickvergessen commented Jul 30, 2013

nickvergessen Sep 10, 2013

Choose a reason for hiding this comment

naderman commented Sep 10, 2013

naderman commented Sep 10, 2013

imkingdavid Sep 18, 2013

Choose a reason for hiding this comment

naderman Sep 19, 2013

Choose a reason for hiding this comment

bantu Sep 19, 2013

Choose a reason for hiding this comment

dhruvgoel92 commented Sep 24, 2013

dhruvgoel92 commented Sep 24, 2013

EXreaction commented Sep 24, 2013

dhruvgoel92 Sep 24, 2013

Choose a reason for hiding this comment

nickvergessen commented Sep 24, 2013