Group join approved notification #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et/11745 * 'ticket/11744' of github.com:EXreaction/phpbb3: [ticket/11744] Helper function to assert notifications in base test
| @@ -414,6 +414,8 @@ | |||
| 2 => '<strong>%d</strong> Notifications', | |||
| ), | |||
| 'NOTIFICATION_BOOKMARK' => '%1$s replied to the topic "%2$s" you have bookmarked.', | |||
| 'NOTIFICATION_GROUP_REQUEST' => '%1$s is requesting to join the group %2$s.', | |||
| 'NOTIFICATION_GROUP_REQUEST_APPROVED' => 'Your request to join the "%1$s" group on has been approved.', | |||
There was a problem hiding this comment.
the "on" sounds wrong to me?
And maybe order the same way as in the previous sentence.
Your request to join the group %1$s has been approved.
| $row = $this->db->sql_fetchrow($result); | ||
| $this->db->sql_freeresult($result); | ||
|
|
||
| return (!empty($row)) ? true : false; |
There was a problem hiding this comment.
Nitpicky, but that could be shortened to just:
return !empty($row);
imkingdavid
added a commit
that referenced
this pull request
Sep 13, 2013
Group join approved notification
|
Why was this merged, even the the email notification is removed which i pointed out and obviously would have required some discussion on whether this is the way to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #1617
http://tracker.phpbb.com/browse/PHPBB3-11745