[ticket/11755] MySQL upgrader out of date #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
De-duplicating code from create_schema_files, mysql_upgrader. New file phpbb/db/schema_data which contains all the current schema data. New function in db_tools public static function get_dbms_type_map() to make the type map available everywhere (without requiring $db be setup already) PHPBB3-11755
|
The problem here is that mysql_upgrader.php is a tool that people download (as a single file) and run from their phpBB root folder. This is no longer possible post-patch. |
|
Don't they need to get the upgrader based on the current version they have installed because of the schema differences? |
|
Yeah, that's what they do. See e.g. https://www.phpbb.com/kb/article/doesnt-have-a-default-value-errors/ |
|
Then that would still be possible--it includes the two required files that are in the phpbb/db/ directory. |
|
Ahem yeah, that sounds good. Maybe we can even get rid of the create schema files and have the schema files created on the fly during install. But this is a different problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De-duplicating code from create_schema_files, mysql_upgrader.
New file phpbb/db/schema_data which contains all the current schema data.
New function in db_tools public static function get_dbms_type_map() to make the
type map available everywhere (without requiring $db be setup already)
http://tracker.phpbb.com/browse/PHPBB3-11755