Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ticket/10120] Make profiles publicly viewable by default #412

Closed
wants to merge 3 commits into from

Conversation

igorw
Copy link
Contributor

@igorw igorw commented Oct 13, 2011

Give guests u_viewprofile permission.

http://tracker.phpbb.com/browse/PHPBB3-10120

Give guests u_viewprofile permission.

PHPBB3-10120
@@ -620,7 +620,7 @@ INSERT INTO phpbb_acl_roles_data (role_id, auth_option_id, auth_setting) SELECT
# Permissions

# GUESTS - u_download and u_search ability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs to be updated now that viewprofile permission is also granted.

@imkingdavid
Copy link
Contributor

As discussed in the ticket, still to be done are:

  1. make newly registered users' profiles only viewable to registered users
  2. deny profile access to bots by default (can be allowed per bot, I think?)

@p
Copy link
Contributor

p commented Mar 9, 2012

@p
Copy link
Contributor

p commented Mar 9, 2012

  1. make newly registered users' profiles only viewable to registered users

What is needed for this?

  1. deny profile access to bots by default (can be allowed per bot, I think?)

I assumed this was already the case?

@EXreaction
Copy link
Contributor

  1. make newly registered users' profiles only viewable to registered users

If this is for spam purposes, we will be having the new permission to not allow new users to update some profile fields.

  1. deny profile access to bots by default (can be allowed per bot, I think?)

I think that bots should be able to view something if guests are able to.

@p
Copy link
Contributor

p commented Dec 5, 2012

igorw#17

[ticket/10120] Update comment to indicate that guests can now view profi...
@EXreaction
Copy link
Contributor

@igorw you plan on adding profile view access to bots? I do not think that search bots typically like being discriminated against (they can't see things normal guests can).

@nickvergessen
Copy link
Contributor

What's the status here? I think its fine for merge, as I agree on

I think that bots should be able to view something if guests are able to.

also as for

make newly registered users' profiles only viewable to registered users

If this is for spam purposes, we will be having the new permission to not allow new users to update some profile fields.

is already merged

@p
Copy link
Contributor

p commented Apr 17, 2013

Ideally tests for 1) ability of guests to view profiles, 2) ability or inability of bots to view profiles (still not clear which is the case with the patch).

@nickvergessen
Copy link
Contributor

Replaced by #1351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants