-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ticket/10120] Make profiles publicly viewable by default #412
Conversation
Give guests u_viewprofile permission. PHPBB3-10120
@@ -620,7 +620,7 @@ INSERT INTO phpbb_acl_roles_data (role_id, auth_option_id, auth_setting) SELECT | |||
# Permissions | |||
|
|||
# GUESTS - u_download and u_search ability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment needs to be updated now that viewprofile permission is also granted.
As discussed in the ticket, still to be done are:
|
…ofiles. PHPBB3-10120
What is needed for this?
I assumed this was already the case? |
If this is for spam purposes, we will be having the new permission to not allow new users to update some profile fields.
I think that bots should be able to view something if guests are able to. |
[ticket/10120] Update comment to indicate that guests can now view profi...
@igorw you plan on adding profile view access to bots? I do not think that search bots typically like being discriminated against (they can't see things normal guests can). |
What's the status here? I think its fine for merge, as I agree on
also as for
is already merged |
Ideally tests for 1) ability of guests to view profiles, 2) ability or inability of bots to view profiles (still not clear which is the case with the patch). |
Replaced by #1351 |
Give guests u_viewprofile permission.
http://tracker.phpbb.com/browse/PHPBB3-10120