[ticket/8652] Sending 2 emails on 2 replies #601
Conversation
|
Code looks good, I just do not like the comment. It does not explain the problem. |
|
Applied the changes requested. |
|
Still do not like it. We especially use the words: board, forum, topic, post. |
|
Also please make sure your commits follow http://wiki.phpbb.com/Git#Commit_Messages, but I can also fix that for you if you'd prefer. |
|
Hum... I was thinking my commit message was correct according to the guidelines. After reading them, I'm the same. |
|
The commit 4cbb697 has lines longer than 80 characters per line. |
This is a fix for the problem of the system sending 2 emails when there are 2 replies to a topic where the user is subscribed in a topic and the forum that contains the topic. This simple fix seems to solve the problem. In simple tests I made it shows it does. PHPBB3-8652
Changed the comment by request to a more verbose version. This version is supposed to explain better which problem is it trying to solve and why that code is not a bad idea to solve the problem (in therms of performace hit caused by the extra DB query which is actually only a performance hit if no user is subscribed to the forum that includes that thread, which is something very rare). PHPBB3-8652
|
Merged as d67fae0 |
This is a fix for the problem of the system sending 2 emails when there are 2 replies to a topic where the user is subscribed in a topic and the forum that contains the topic.
This simple fix seems to solve the problem. In simple tests I made it shows it does.
PHPBB3-8652