[ticket/10799] Removing global variable from includejs #787
Conversation
| @@ -48,7 +48,7 @@ class phpbb_template | |||
| * phpBB root path | |||
| * @var string | |||
| */ | |||
| private $phpbb_root_path; | |||
| public $phpbb_root_path; | |||
There was a problem hiding this comment.
Why does this need to become public? Can't _js_include just prefix it's parameter with $this->phpbb_root_path?
There was a problem hiding this comment.
$this refers to template renderer instance, not template.
I can add phpbb_root_path to renderer and then change it to $this->phpbb_root_path. Would it be a better solution than changing template's phpbb_root_path to public?
There was a problem hiding this comment.
I think you misunderstood what I meant. Shouldn't the _js_include() function simply add $this->phpbb_root_path in front? But I guess it's cleaner if that function can take any path and won't always prepend the root path.
But I would definitely prefer that you pass $phpbb_root_path into the renderer over the current public solution.
Removing global $phpbb_root_path from includejs implementation PHPBB3-10799
|
Changed. Moved it to _js_include() function, so it could use template's phpbb_root_path variable |
|
Looks good :) |
* cyberalien/ticket/10799: [ticket/10799] Removing global variable from includejs
Removing global $phpbb_root_path from includejs implementation
http://tracker.phpbb.com/browse/PHPBB3-10799