WIP: [feature/moderator-needed] Display # of Items Requiring Moderator Attention

[imkingdavid]

Old PR: #780

Display number of reported posts/PMs and unapproved topics/posts with MCP link for moderators with m_approve and m_report permissions.

Because Unknown Bliss asked me to sort of finish this up, I have begun a new pull request from my own branch so that he does not have to cherry pick my changes into the old PR. I tried to address all of the comments made on the old PR, but if I missed anything, or if you see something else that needs fixing, let me know.

EDIT: bantu suggested:

Since this is for develop, maybe the implementation should be more object oriented and "plugin-aware". Maybe it could be changed so you can just drop in files/classes to add new items requiring moderator attention. Maybe also with the ability to display some information on the index page like http://www.phpbb.com/customise/db/mod/mcp_info_on_index The exising code could be decomposed into two plugins: a) reported posts b) posts in moderation queue

I will look into this later when I have some time. Until then, this needs some testing.

[travisbot]

This pull request fails (merged 7d20c6e into f3d33bf).

[michaelcullum]

Thanks

[senky]

Haven't you forget about subsilver2?

[imkingdavid]

Not forgot, just haven't gotten to it yet. This is a WIP. ;)

[travisbot]

This pull request passes (merged 48ae5e8 into f3d33bf).

[travisbot]

This pull request fails (merged 3da0853 into f3d33bf).

[rmcgirr83]

Seeing as nearly all of the code is being used from a mod I wrote a while ago, wouldn't a "Gee, thanks RMcGirr83" comment in the code be apropos?

/me slaps unknownbliss

[imkingdavid]

I didnt even check this code against your MOD. I figured @unknownbliss had done it himself. I'll be sure to add a credit line for you before this gets merged, unless someone else does it first.

[michaelcullum]

@imkingdavid It was mentioned in the RFC. Also see the first commit message. ;)

[michaelcullum]

Perhaps this should be merged. Later on a template event can be added allowing extensions to add something here, but for now template events aren't merged so that isn't possible.

[imkingdavid]

This is being closed because Reported posts and Posts awaiting approval are two moderator-level notifications introduced by #992 so this would be redundant.