Ticket/11045 Add unit tests for the compress class #976
Conversation
PHPBB3-11045
PHPBB3-11045
PHPBB3-11045
| * | ||
| */ | ||
|
|
||
| require_once __DIR__ . '/../../phpBB/includes/functions.php'; |
There was a problem hiding this comment.
should be dirname(__FILE__)
There was a problem hiding this comment.
Are you sure? naderman told me to use __DIR__ here: #857 (comment)
There was a problem hiding this comment.
Yes. There is no __DIR__ on PHP 5.2 and Olympus support 5.2. Develop doesn't, so it should be __DIR__ there.
There was a problem hiding this comment.
|
Some tests seem to fail. See http://travis-ci.org/#!/phpbb/phpbb3/jobs/2259194 |
|
I believe the tests are failing because the file conflict handling that was added to the compress class was not added to develop-olympus but only develop. I can create a new ticket + PR with a cherry-pick of the file conflict handling into develop-olympus? |
|
Hmm, right, in this case, we'll either just have this on develop only (the old patch) or you'll have to split the tests up into multiple patches. |
|
My vote is for splitting to achieve maximum test coverage everywhere. |
|
@p I agree. |
|
No problem, I'll split it. |
http://tracker.phpbb.com/browse/PHPBB3-11045