Merge 1da292d into d275d27

phpbrew · Aug 2, 2020 · 5ca9a33 · 5ca9a33
2 parents d275d27 + 1da292d
commit 5ca9a33
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/PhpBrew/Downloader/PhpStreamDownloader.php b/src/PhpBrew/Downloader/PhpStreamDownloader.php
@@ -2,6 +2,8 @@
 
 namespace PhpBrew\Downloader;
 
+use RuntimeException;
+
 class PhpStreamDownloader extends BaseDownloader
 {
     protected function process($url, $targetFilePath)
@@ -31,13 +33,16 @@ protected function process($url, $targetFilePath)
             $context = stream_context_create($opts);
             $binary = file_get_contents($url, null, $context);
         }
-        if ($binary !== false) {
-            file_put_contents($targetFilePath, $binary);
+        if ($binary === false) {
+            throw new RuntimeException("Fail to request $url");
+        }
 
-            return true;
+        $res = file_put_contents($targetFilePath, $binary);
+        if ($res === false) {
+            throw new RuntimeException("Failed writing to $targetFilePath");
         }
-        // throw new RuntimeException("Fail to request $url");
-        return false;
+
+        return true;
     }
 
     public function hasSupport($requireSsl)