Adding --with-libedit to configure option affects the behaviour of readline() function.

[shinnya]

readline function implemented with libedit can't stop echoing user input. The code below should not display user input.

<?php    
`/bin/stty -echo`;    
$line = readline('> ');    
var_dump($line);    
`/bin/stty echo`;

This code works with libreadline, but doesn't work with libedit. As far as I searched, --with-libedit causes this issue.

Accordint to PHP doc, we can choose either --with-readline or --with-libedit for enabling readline, but the two options are given in phpbrew at the same time when +readline variant is enabled and phpbrew can find the headers of readline and libedit.
See

phpbrew/src/PhpBrew/VariantBuilder.php

Line 229 in 3b8e0cd

if ($prefix = Utils::findIncludePrefix('editline' . DIRECTORY_SEPARATOR . 'readline.h')) {

.

Is this code a bug? I think we should give either of them.

[shinnya]

You can check which library you use by the following command:

$ php -i | grep EditLine

If you get no output, you're using libreadline.

[c9s]

CLIFramework 2.5.2 was released, which shall contain your commits. :)

[c9s]

It was using editline for historical reason about 4 years ago, it's now fixed to prefer readline over editline