Update getQuery QueryObjectModelInterface method #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
looking at this code, i don't see how this could ever be nullable.
but this is not the right fix - we should remote the ? of getQuery.
very strictly speaking, this is a BC break if somebody overwrote that specific method, but i don't expect people to do that.
changing it in the annotation only is cheating on phpstan and could hide the problem rather than make people notice because of the conflict.
|
@dbu changed the native return type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is not any case where
getQuerycan be null in this method.