add selector name to getValue() and getValues()

[lsmith77]

I was working on implementing support for selectors into Jackalope when I stumbled over this. Since column names are only unique for each selector the current API makes no sense. As such I added a selector parameter (if none is supplied it would fallback to the default selector just like for the other methods).

see also jackalope/jackalope#53

[lsmith77]

nevermind .. i guess the intention is to make the column names unique by qualifying them with the selector name aka "foo.bar"

[dbu]

@lsmith77: sorry, but i strongly disagree with this. we diverge from jcr for no good reason.

i just ran the following code in the JavaDavexClient:

QueryManager qm = s.getWorkspace().getQueryManager();
Query query = qm.createQuery("SELECT * FROM [nt:file] INNER JOIN [nt:folder] AS second ON [nt:file].[jcr:createdBy] = second
QueryResult r = query.execute();
String[] names = r.getColumnNames();
for (String n: names) {
    System.out.println(n);
}

and the output is

nt:file.jcr:createdBy
nt:file.jcr:created
nt:file.jcr:primaryType
second.jcr:createdBy
second.jcr:created
second.jcr:primaryType

so the right way to handle this is that as soon as there is a join, the column name contains the selector name. the jcr spec is not overly precise and explicit there, i guess the overprudent client would use the getColumns to know what names to use, or just getValues and explicitly select fields so he knows what he wants by position instead of key name.

can you please undo this change?

[lsmith77]

i never merged the changes .. i closed the PR