Transaction #6
Transaction #6
Conversation
…tion As there is no transaction standard in PHP this interface should provide a transaction mechanism in a way the original Java UserTransaction interface can be used for transactions while working with the JCR API.
(see comments of former commit)
| * application is not allowed to commit the transaction. | ||
| * @throws LogicException Thrown if the current session is not associated | ||
| * with a transaction. | ||
| * @throws \PHPCR\RepositoryException Thrown if the transaction implementation |
There was a problem hiding this comment.
i assume a timeout would qualify for this exception?
There was a problem hiding this comment.
I tried to stay close to the Java spec. There is no exception that is more specific. So yes, I guess a time out would qualify for this one.
…associated with a session
|
ok, then i dont have any more feedback. i will poke the midgard guys. |
|
begin() "Create a new transaction and associate it with the current session." It rather should be: "Begins new transaction associated with current session." A session is responsible to create transaction. |
| namespace PHPCR\Transaction; | ||
|
|
||
| /** | ||
| * As there is no transaction standard in PHP this interface should provide a |
There was a problem hiding this comment.
sorry, somehow github lost my comment on this apparently.
i would suggest to just explain to the php user how the transaction works. and have a note that this is not part of jcr as there is a java standard, and put all the details into doc/JCR_TO_PHPCR.txt
There was a problem hiding this comment.
done, or do you think more info on how to deal with transactions should be provided here?
|
like this. apart from the doc issue (jcr-to-phpcr.txt) i just commented, i think it can be merged. |
Interface for transactions derived from javax.transaction.UserTransaction