Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting sourceFile on the reader when importing streams #60

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

johan-lejdung
Copy link
Contributor

fixes a bug where it wasn't possible to import from more than one stream at a time. As described in #59

fixes a bug where it wasn't possible to import from more than one stream at a time
@johan-lejdung
Copy link
Contributor Author

@phpdave11 anything else I can do to help move this along?

@dekiftw
Copy link

dekiftw commented Mar 28, 2024

@phpdave11 I have tested this fix and can confirm that it works!
I kindly ask that this PR gets merged as soon as possible.

@johan-lejdung
Copy link
Contributor Author

johan-lejdung commented Mar 30, 2024

I should mention that we've been running this code in Production since my bugfix, we haven't had any issues with it as of yet.

Are any of the contributors active? @phpdave11 @mrtsbt @mcdee @awesomeunleashed

@awesomeunleashed
Copy link
Contributor

Are any of the contributors active? @phpdave11 @mrtsbt @mcdee @awesomeunleashed

I don't have merge permissions, so I can't help you there unfortunately.

@phpdave11
Copy link
Owner

Thank you! I will merge this PR now and create a new gofpdi and gofpdf release tonight.

@phpdave11 phpdave11 merged commit 828e193 into phpdave11:master Mar 30, 2024
@romanpickl
Copy link

@phpdave11 the release wasn't created yet, right?

@johan-lejdung
Copy link
Contributor Author

Seems it's still missing :/

@phpdave11 the release wasn't created yet, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants