This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
Use DTF instead of InstallUtil to call our custom actions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we no longer need to care for older Windows installations (see phpmanager#45), switch back to using DTF to call our custom actions. For a couple of good reasons why DTF is a good idea, see http://lists.wixtoolset.org/pipermail/wix-users-wixtoolset.org/2021-March/009681.html This also fixes the upgrade routine. Fixes: phpmanager#28
|
Hi, any updates? |
|
Limited resources to finish testing it on all supported platforms. Probably some time in the summer. |
|
Okay. If there is anything I can help you with, please let me know. |
|
@lextm Any update on getting this merged? It would solve two open issues on the board currently. I had the same issue with 2.7 install where the icon disappeared in IIS. Running a repair on the installation resolved the issue. |
|
Done in #57 by reverting to a very old version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we no longer need to care for older Windows installations (see #45),
switch back to using DTF to call our custom actions.
For a couple of good reasons why DTF is a good idea, see
http://lists.wixtoolset.org/pipermail/wix-users-wixtoolset.org/2021-March/009681.html
This also fixes the upgrade routine.
Fixes: #28